tmysik commented on code in PR #5678:
URL: https://github.com/apache/netbeans/pull/5678#discussion_r1141628232


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -531,11 +532,11 @@ private String composeFunctionDoc(String description, 
String parameters, String
         }
 
         private String composeParameterLine(PHPDocVarTypeTag param) {
-            return composeParameterLine(param.getTypes(), 
param.getVariable().getValue(), param.getDocumentation());
+            return composeParameterLine(param.getTypes(), 
param.getVariable().getValue(), param.getDocumentation(), param);

Review Comment:
   Nitpick: we are passing several fields of `param` but then, as the last 
parameter, we pass `param` itself. Maybe we could pass only 1 argument? I am 
not sure, just noticed it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to