ebarboni commented on PR #5679: URL: https://github.com/apache/netbeans/pull/5679#issuecomment-1479392577
> I forgot updating: https://github.com/apache/netbeans/blob/4c90ff36e0ac1d80b324b76fca0befc13bd750f6/java/maven.embedder/external/binariesembedded-list > > this is called manually from > > https://github.com/apache/netbeans/blob/4c90ff36e0ac1d80b324b76fca0befc13bd750f6/java/maven.embedder/build.xml#L30-L33 > > and also from: > > https://github.com/apache/netbeans/blob/4c90ff36e0ac1d80b324b76fca0befc13bd750f6/nbbuild/build.xml#L248-L252 > > this runs checksums again over the contents of the zip, additional to the checksum over the zip itself. > > @ebarboni I suppose I have to update this too? Yes this is needed :D. Was looking at doing a PR for 3.8.8 but see yours for 3.9.1. I wonder if jdom1.0 references is needed ? I do a test removing it and it compiles ok. (maven dependency try still needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
