mbien commented on code in PR #5823:
URL: https://github.com/apache/netbeans/pull/5823#discussion_r1165947585
##########
java/maven.grammar/src/org/netbeans/modules/maven/grammar/MavenProjectGrammar.java:
##########
@@ -464,6 +468,70 @@ protected Enumeration<GrammarResult>
getDynamicValueCompletion(String path, Hint
return Collections.enumeration(elems);
}
}
+ // version property completion
+ if (path.startsWith("/project/properties/") && path.indexOf("/", 20)
== -1) {
Review Comment:
this should make it hopefully fairly safe for inclusion. The code path is
guarded by the xpath (basically), so it doesn't affect any other completion
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
