neilcsmith-net commented on PR #5620: URL: https://github.com/apache/netbeans/pull/5620#issuecomment-1511038055
> For example, vscode _brands_ the default setting to NEVER. So it is not explicitly set (by the user). It will be also implicitly set by **importing** old settings by a new installation - and this is the case, where it _might_ be valid to do one-time fetch. If it's branded, it's been explicitly set by the application developer, if imported settings it has been explicitly set at some point by the user. In either case, it seems wrong to ever connect without manual interaction. This is still marked for NB18. Given the other changes have addressed immediate concerns in VSCode, do you want to adapt this PR for NB18 or NB19, or close it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
