matthiasblaesing commented on code in PR #5714:
URL: https://github.com/apache/netbeans/pull/5714#discussion_r1179414318
##########
ide/db/src/org/netbeans/modules/db/explorer/dlg/CreateTableDialog.java:
##########
@@ -471,7 +471,7 @@ public DataTable(TableModel model) {
Map cmap = ColumnItem.getColumnProperty(i);
col.setIdentifier(cmap.get("name")); //NOI18N
columnName = NbBundle.getMessage (CreateTableDialog.class,
"CreateTable_" + i); //NOI18N
- columnWidth = (new
Double(getFontMetrics(getFont()).getStringBounds(columnName,
getGraphics()).getWidth())).intValue() + 20;
+ columnWidth =
Double.valueOf(getFontMetrics(getFont()).getStringBounds(columnName,
getGraphics()).getWidth()).intValue() + 20;
Review Comment:
Seems to be unchanged, maybe you forgot to add this?
##########
ide/editor.completion/src/org/netbeans/modules/editor/completion/PatchedHtmlRenderer.java:
##########
@@ -176,7 +176,7 @@ private static double _renderPlainString(
}
double chWidth = wid / chars.length;
- int estCharsToPaint = new Double(w / chWidth).intValue();
+ int estCharsToPaint = Double.valueOf(w / chWidth).intValue();
Review Comment:
You write agreed, but it is not done. Please recheck (the same is true for
the other locations in this file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
