matthiasblaesing commented on code in PR #6089:
URL: https://github.com/apache/netbeans/pull/6089#discussion_r1238938708
##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/api/NBArtifactInfo.java:
##########
@@ -40,7 +40,7 @@ public NBArtifactInfo(String name) {
this.name = name;
}
- public boolean removeVersionInfo(Object o) {
+ public boolean removeVersionInfo(NBVersionInfo o) {
Review Comment:
From my POV: If a module declares an API, we need to be correct with it.
NetBeans has a level for what you describe: It is an implementation dependency.
These are hard-tied to the corresponding NetBeans build.
So I see outs here: Bump major or just leave it as is. It is a minor
problem, not worth breaking API for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
