matthiasblaesing commented on code in PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#discussion_r1244269706
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizard.java:
##########
@@ -135,17 +138,26 @@ public void initialize(WizardDescriptor wizardDescriptor)
{
@Override
public Set instantiate() throws IOException {
+ Project project = Templates.getProject(wiz);
+
+ JPAModuleInfo moduleInfo =
project.getLookup().lookup(JPAModuleInfo.class);
+ Double webXmlVersion = Double.parseDouble(moduleInfo.getVersion());
+
+ String enterprisePrefix = "jakarta";
+ if (webXmlVersion < JAKARTA_EE_9_WEB_APP_DD_VERSION) {
Review Comment:
Wouldn't it make sense to use the mechanism modified in
`PersistentenceClientEntitySelectionVisual.java` (Classpath checking) to decide
which variant to use? `JPAModuleInfo` might not represent a web, but an EJB
module, not sure how the versionioning is currently, but you might have to
check `type` in addtion to `version`.
##########
enterprise/j2ee.ejbcore/nbproject/org-netbeans-modules-j2ee-ejbcore.sig:
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests
getInputMethodRequests()
meth public java.awt.image.ColorModel getColorModel()
meth public java.awt.image.VolatileImage createVolatileImage(int,int)
meth public java.awt.image.VolatileImage
createVolatileImage(int,int,java.awt.ImageCapabilities) throws
java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()
Review Comment:
This is surprising. And checking history, yes it should not be there. Don't
know why it was removed, but we should not regress.
https://github.com/apache/netbeans/commit/53a7a7594f77d68584acd94aeee9ff6c206e82cd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
