mbien commented on code in PR #6160: URL: https://github.com/apache/netbeans/pull/6160#discussion_r1257515484
########## enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/MavenJsfReferenceImplementationProvider.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.maven.j2ee; + +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Collections; +import java.util.EnumMap; +import java.util.Map; +import org.apache.maven.artifact.Artifact; +import org.apache.maven.artifact.repository.ArtifactRepository; +import org.apache.maven.artifact.resolver.ArtifactNotFoundException; +import org.apache.maven.artifact.resolver.ArtifactResolutionException; +import static org.apache.maven.repository.RepositorySystem.DEFAULT_REMOTE_REPO_ID; +import static org.apache.maven.repository.RepositorySystem.DEFAULT_REMOTE_REPO_URL; +import org.netbeans.modules.maven.embedder.EmbedderFactory; +import org.netbeans.modules.maven.embedder.MavenEmbedder; +import org.netbeans.modules.web.jsfapi.api.JsfVersion; +import org.netbeans.modules.web.jsfapi.spi.JsfReferenceImplementationProvider; +import org.openide.util.Exceptions; +import org.openide.util.lookup.ServiceProvider; + +/** + * + * @author Benjamin Asbach + */ +@ServiceProvider(service = JsfReferenceImplementationProvider.class) +public class MavenJsfReferenceImplementationProvider implements JsfReferenceImplementationProvider { + + static final Map<JsfVersion, String> JSF_VERSION_MAVEN_COORDINATES_MAPPING; + static { + EnumMap<JsfVersion, String> map = new EnumMap<>(JsfVersion.class); + map.put(JsfVersion.JSF_1_0, "javax.faces:jsf-impl:1.1_02"); //seems to be not available in maven central + map.put(JsfVersion.JSF_1_1, "javax.faces:jsf-impl:1.1_02"); + map.put(JsfVersion.JSF_1_2, "javax.faces:jsf-impl:1.2"); + map.put(JsfVersion.JSF_2_0, "com.sun.faces:jsf-impl:2.0.11"); + map.put(JsfVersion.JSF_2_1, "com.sun.faces:jsf-impl:2.1.29"); + map.put(JsfVersion.JSF_2_2, "com.sun.faces:jsf-impl:2.2.20"); + map.put(JsfVersion.JSF_2_3, "org.glassfish:jakarta.faces:2.3.19"); + map.put(JsfVersion.JSF_3_0, "org.glassfish:jakarta.faces:3.0.4"); + map.put(JsfVersion.JSF_4_0, "org.glassfish:jakarta.faces:4.0.2"); + JSF_VERSION_MAVEN_COORDINATES_MAPPING = Collections.unmodifiableMap(map); + } + + @Override + public Path of(JsfVersion jsfVersion) { + String mavenCoordinates[] = JSF_VERSION_MAVEN_COORDINATES_MAPPING.get(jsfVersion).split(":"); + if (mavenCoordinates.length != 3) { + return null; + } + String groupId = mavenCoordinates[0]; + String artifactId = mavenCoordinates[1]; + String version = mavenCoordinates[2]; + + MavenEmbedder mavenEmbedder = EmbedderFactory.getOnlineEmbedder(); + + ArtifactRepository localRepository = mavenEmbedder.getLocalRepository(); + ArtifactRepository remoteRepository = mavenEmbedder.createRemoteRepository(DEFAULT_REMOTE_REPO_URL, DEFAULT_REMOTE_REPO_ID); + Artifact jsfRIArtifact = mavenEmbedder.createArtifact(groupId, artifactId, version, "jar"); + + try { + mavenEmbedder.resolve(jsfRIArtifact, Collections.singletonList(remoteRepository), localRepository); Review Comment: i checked and all calls are made from a request processor thread which is good. Cache might not be needed since subsequent `resolve` invocations are fairly fast anyway. looking at the code it should use the maven proxy settings I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
