breakponchito commented on PR #5847: URL: https://github.com/apache/netbeans/pull/5847#issuecomment-1633332438
> @breakponchito I am going to add a commit - I hope this is ok. I wanted to add review comments but it is faster to code it right away since some of it is UI. > > * made the wizard panel a bit more compact and layout gaps more consistent > * removed a file chooser component which was stored in the form but not used > * the text fields should validate on input change rather than action performed (which is pressing return). Otherwise the user can't simply type `/tmp` and press finish. For that we can use a `DocumentListener` > * code cleanup: overrides, generics, arm blocks, compiler warnings etc > * fixed a NPE which happened while closing the wizard. > > ``` > java.lang.NullPointerException: Cannot invoke "org.openide.WizardDescriptor.putProperty(String, Object)" because "this.wizardDescriptor" is null > at org.netbeans.modules.fish.payara.jakarta.transformer.TransformerWizardIterator.uninitialize(TransformerWizardIterator.java:446) > at org.openide.loaders.TemplateWizard$InstantiatingIteratorBridge.uninitialize(TemplateWizard.java:1076) > at org.openide.loaders.TemplateWizardIterImpl.uninitialize(TemplateWizardIterImpl.java:215) > at org.openide.loaders.TemplateWizardIteratorWrapper.uninitialize(TemplateWizardIteratorWrapper.java:131) > at org.openide.WizardDescriptor.callUninitialize(WizardDescriptor.java:1541) > at org.openide.WizardDescriptor.resetWizardOpen(WizardDescriptor.java:1383) > at org.openide.WizardDescriptor.resetWizard(WizardDescriptor.java:1362) > [catch] at org.openide.WizardDescriptor.setValueOpen(WizardDescriptor.java:1346) > ``` thank you for your fixes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
