pepness commented on code in PR #6542:
URL: https://github.com/apache/netbeans/pull/6542#discussion_r1353708741
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/ConfigBuilderProvider.java:
##########
@@ -193,16 +209,13 @@ public static ConfigBuilder getBuilder(final
GlassFishServer server) {
"GlassFish server entity shall not be null");
}
ConfigBuilder builder;
- synchronized (builders) {
- builder = builders.get(server);
- if (builder != null) {
- return builder;
- }
- String serverHome = server.getServerHome();
- builder = new ConfigBuilder(config, serverHome, serverHome,
serverHome);
- builders.put(server, builder);
+ builder = builders.computeIfPresent(server, (key, value) -> value);
+ if (builder != null) {
+ return builder;
}
- return builder;
+ String serverHome = server.getServerHome();
+ return builders.computeIfAbsent(server, key ->
+ new ConfigBuilder(config, serverHome, serverHome, serverHome));
Review Comment:
The `computeIfPresent` implementation from `ConcurrentHashMap` synchronize
at a node level (`Node<K,V>`). I use `computeIfPresent` to circumvent the need
of synchronize the entire map. It does work like a `get()` (`get()` does not
synchronize) and it does not have the `@Deprecated` as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
