matthiasblaesing commented on issue #5024:
URL: https://github.com/apache/netbeans/issues/5024#issuecomment-1763392759

   I had a look at the PR and I think all changes outside 
`JavaBracesMatcher.java` should not be there. of course you can try to change 
the lexing strategy for the java language in NetBeans, but that will be an 
uphill battle. I suggest to modify the braces matcher to deal with situations 
where characters do not map to a single token.
   
   The java lexer can generate these tokens, that could match your case:
   
   - JavaTokenId.LT
   - JavaTokenId.LTLT
   - JavaTokenId.LTLTEQ
   - JavaTokenId.GT
   - JavaTokenId.GTEQ
   - JavaTokenId.GTGT
   - JavaTokenId.GTGTEQ
   - JavaTokenId.GTGTGT
   - JavaTokenId.GTGTGTEQ
   
   For example this code:
   
   ```java
   
   import java.util.HashMap;
   import java.util.List;
   import java.util.Map;
   import java.util.UUID;
   
   
   public class testLexer<V> {
       public static <K,V2> void add(K k, V2 v) {}
   
       public static void main(String[] argv) {
           Map<String,Map<UUID,List<Map<Integer,Number>>>> m = new HashMap<>();
       }
   }
   ```
   
   is lexed to this token stream:
   
   ```
   IMPORT          "import", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "java", la=1
   DOT             ".", la=1
   IDENTIFIER      "util", la=1
   DOT             ".", la=1
   IDENTIFIER      "HashMap", la=1
   SEMICOLON       ";"
   WHITESPACE      "\n", la=1
   IMPORT          "import", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "java", la=1
   DOT             ".", la=1
   IDENTIFIER      "util", la=1
   DOT             ".", la=1
   IDENTIFIER      "List", la=1
   SEMICOLON       ";"
   WHITESPACE      "\n", la=1
   IMPORT          "import", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "java", la=1
   DOT             ".", la=1
   IDENTIFIER      "util", la=1
   DOT             ".", la=1
   IDENTIFIER      "Map", la=1
   SEMICOLON       ";"
   WHITESPACE      "\n", la=1
   IMPORT          "import", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "java", la=1
   DOT             ".", la=1
   IDENTIFIER      "util", la=1
   DOT             ".", la=1
   IDENTIFIER      "UUID", la=1
   SEMICOLON       ";"
   WHITESPACE      "\n\n\n", la=1
   PUBLIC          "public", la=1
   WHITESPACE      " ", la=1
   CLASS           "class", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "testLexer", la=1
   LT              "<", la=1
   IDENTIFIER      "V", la=1
   GT              ">", la=1
   WHITESPACE      " ", la=1
   LBRACE          "{"
   WHITESPACE      "\n    ", la=1
   PUBLIC          "public", la=1
   WHITESPACE      " ", la=1
   STATIC          "static", la=1
   WHITESPACE      " ", la=1
   LT              "<", la=1
   IDENTIFIER      "K", la=1
   COMMA           ","
   IDENTIFIER      "V2", la=1
   GT              ">", la=1
   WHITESPACE      " ", la=1
   VOID            "void", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "add", la=1
   LPAREN          "("
   IDENTIFIER      "K", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "k", la=1
   COMMA           ","
   WHITESPACE      " ", la=1
   IDENTIFIER      "V2", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "v", la=1
   RPAREN          ")"
   WHITESPACE      " ", la=1
   LBRACE          "{"
   RBRACE          "}"
   WHITESPACE      "\n\n    ", la=1
   PUBLIC          "public", la=1
   WHITESPACE      " ", la=1
   STATIC          "static", la=1
   WHITESPACE      " ", la=1
   VOID            "void", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "main", la=1
   LPAREN          "("
   IDENTIFIER      "String", la=1
   LBRACKET        "["
   RBRACKET        "]"
   WHITESPACE      " ", la=1
   IDENTIFIER      "argv", la=1
   RPAREN          ")"
   WHITESPACE      " ", la=1
   LBRACE          "{"
   WHITESPACE      "\n        ", la=1
   IDENTIFIER      "Map", la=1
   LT              "<", la=1
   IDENTIFIER      "String", la=1
   COMMA           ","
   IDENTIFIER      "Map", la=1
   LT              "<", la=1
   IDENTIFIER      "UUID", la=1
   COMMA           ","
   IDENTIFIER      "List", la=1
   LT              "<", la=1
   IDENTIFIER      "Map", la=1
   LT              "<", la=1
   IDENTIFIER      "Integer", la=1
   COMMA           ","
   IDENTIFIER      "Number", la=1
   GTGTGT          ">>>", la=1
   GT              ">", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "m", la=1
   WHITESPACE      " ", la=1
   EQ              "=", la=1
   WHITESPACE      " ", la=1
   NEW             "new", la=1
   WHITESPACE      " ", la=1
   IDENTIFIER      "HashMap", la=1
   LT              "<", la=1
   GT              ">", la=1
   LPAREN          "("
   RPAREN          ")"
   SEMICOLON       ";"
   WHITESPACE      "\n    ", la=1
   RBRACE          "}"
   WHITESPACE      "\n", la=1
   RBRACE          "}"
   ----- EOF -----
   ```
   
   The dump was generated by saving the java file to 
`java/java.lexer/test/unit/data/testfiles/testLexer.java`, adding 
   
   ```java
       public void test2() throws Exception {
           LexerTestUtilities.checkTokenDump(this, "testfiles/testLexer.java",
                   JavaTokenId.language());
       }
   ```
   
   to `JavaTokenDumpTest` and running that test.
   
   In the sample you find both `GT` and `GTGTGT`. I don't know _why_ it was 
done this way, but I would start with the assumption, that they author made a 
sane decision there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to