mbien commented on code in PR #113: URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/113#discussion_r1382474144
########## .mvn/wrapper/maven-wrapper.jar: ########## Review Comment: i am not a fan of binaries in repos. I think the mvnw launcher script can download this jar, right? We could use gh caching to be a nice internet citizen if needed - but this is a low throughput repo, so I am not super worried about that download atm (the cache would probably invalidate between rebuilds) :) @neilcsmith-net what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
