sdedic commented on code in PR #6673:
URL: https://github.com/apache/netbeans/pull/6673#discussion_r1388594055
##########
enterprise/micronaut/test/unit/src/org/netbeans/modules/micronaut/gradle/MicronautGradleArtifactsImplTest.java:
##########
@@ -40,6 +44,14 @@
*/
public class MicronautGradleArtifactsImplTest extends NbTestCase {
+ static {
+ // TODO remove ASAP from MicronautGradleArtifactsImplTest and
ProjectViewTest
+ // investigate "javax.net.ssl.SSLHandshakeException: Received fatal
alert: handshake_failure"
+ // during gradle download "at
org.netbeans.modules.gradle.spi.newproject.TemplateOperation$InitStep.execute(TemplateOperation.java:317)"
+ // this looks like a misconfigured webserver to me
+ System.setProperty("https.protocols", "TLSv1.2");
+ }
Review Comment:
Probably yes. I'd suggest to document the requirement to set that property
in gradle's `arch.xml` or somewhere, since any testsuite that uses gradle
project as test data may suffer from the same mystery.
Re. cipher suites: according to the capture, the client (that is: our CI
machine) **started** the handshake by offering different set of capabilities -
there was no message whatsoever from the server before that (all payloads
before Client Hello were zero length). The certificate is sent after server
hello (which happens after client hello).
So the difference was IMHO not caused by potentially load-balanced server
sending something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
