ebarboni commented on code in PR #121:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/121#discussion_r1389288259
##########
pom.xml:
##########
@@ -17,212 +18,297 @@
specific language governing permissions and limitations
under the License.
-->
- <modelVersion>4.0.0</modelVersion>
+ <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.netbeans</groupId>
- <artifactId>netbeans-parent</artifactId>
- <version>4</version>
- </parent>
+ <parent>
+ <groupId>org.apache.netbeans</groupId>
+ <artifactId>netbeans-parent</artifactId>
+ <version>4</version>
+ </parent>
- <groupId>org.apache.netbeans.utilities</groupId>
- <artifactId>utilities-parent</artifactId>
- <version>14.0-SNAPSHOT</version>
- <packaging>pom</packaging>
+ <groupId>org.apache.netbeans.utilities</groupId>
+ <artifactId>utilities-parent</artifactId>
+ <version>14.0-SNAPSHOT</version>
+ <packaging>pom</packaging>
- <name>Apache Netbeans Maven Utilities</name>
- <description>Apache Netbeans Maven Utilities is a set of artefacts to
build and populate Apache NetBeans artefacts using Apache Maven</description>
- <url>https://bits.netbeans.org/mavenutilities/nbm-maven-plugin</url>
- <licenses>
- <license>
- <name>The Apache Software License, Version 2.0</name>
- <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
- <distribution>repo</distribution>
- </license>
- </licenses>
+ <name>Apache Netbeans Maven Utilities</name>
+ <description>Apache Netbeans Maven Utilities is a set of artefacts to build
and populate Apache NetBeans artefacts using Apache Maven</description>
+ <url>https://bits.netbeans.org/mavenutilities/nbm-maven-plugin</url>
+ <licenses>
+ <license>
+ <name>The Apache Software License, Version 2.0</name>
+ <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+ <distribution>repo</distribution>
+ </license>
+ </licenses>
- <modules>
- <module>nb-shared</module>
- <module>nbm-maven-harness</module>
- <module>nb-repository-plugin</module>
- <module>nbm-maven-plugin</module>
- </modules>
+ <modules>
+ <module>nb-shared</module>
+ <module>nbm-maven-harness</module>
+ <module>nb-repository-plugin</module>
+ <module>nbm-maven-plugin</module>
+ </modules>
- <scm>
-
<connection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git</connection>
-
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git</developerConnection>
-
<url>https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin</url>
- <tag>HEAD</tag>
- </scm>
- <issueManagement>
- <system>jira</system>
- <url>https://issues.apache.org/jira/browse/NETBEANSINFRA</url>
- </issueManagement>
- <distributionManagement>
- <site>
- <id>netbeans.bits</id>
-
<url>https://bits.netbeans.org/mavenutilities/nbm-maven-plugin/</url>
- </site>
- </distributionManagement>
+ <scm>
+
<connection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git</connection>
+
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/netbeans-mavenutils-nbm-maven-plugin.git</developerConnection>
+ <tag>HEAD</tag>
+ <url>https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin</url>
+ </scm>
+ <issueManagement>
+ <system>jira</system>
+ <url>https://issues.apache.org/jira/browse/NETBEANSINFRA</url>
+ </issueManagement>
+ <distributionManagement>
+ <site>
+ <id>netbeans.bits</id>
+ <url>https://bits.netbeans.org/mavenutilities/nbm-maven-plugin/</url>
+ </site>
+ </distributionManagement>
- <properties>
- <!-- <mojo.java.target>1.6</mojo.java.target> -->
- <maven.version>3.9.5</maven.version>
- <maven.minimum.version>3.6.3</maven.minimum.version>
- <maven.plugin.version>3.10.1</maven.plugin.version>
- <skin.groupId>org.apache.maven.skins</skin.groupId>
- <skin.artifactId>maven-fluido-skin</skin.artifactId>
- <skin.version>1.12.0</skin.version>
- </properties>
+ <properties>
+ <!-- <mojo.java.target>1.6</mojo.java.target> -->
+ <maven.version>3.9.5</maven.version>
+ <maven.minimum.version>3.6.3</maven.minimum.version>
+ <maven.plugin.version>3.10.1</maven.plugin.version>
+ <skin.groupId>org.apache.maven.skins</skin.groupId>
+ <skin.artifactId>maven-fluido-skin</skin.artifactId>
+ <skin.version>1.12.0</skin.version>
+ </properties>
- <dependencyManagement>
- <dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.13.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.ant</groupId>
+ <artifactId>ant</artifactId>
+ <version>1.10.14</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven.plugin-tools</groupId>
+ <artifactId>maven-plugin-annotations</artifactId>
+ <version>${maven.plugin.version}</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <artifactId>maven-clean-plugin</artifactId>
+ <version>3.3.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <version>3.1.1</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>3.3.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.6.1</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>3.1.0</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <version>3.4.1</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.2.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-site-plugin</artifactId>
+ <version>3.12.1</version>
+ <!-- version sensitive to maven-fluido-skin version -->
+ <configuration>
+ <!-- hard coded work here,
${project.distributionManagement.site.url} move everything
+ to staging root removing the "parent " -->
+
<topSiteURL>https://bits.netbeans.org/mavenutilities/nbm-maven-plugin/</topSiteURL>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>animal-sniffer-maven-plugin</artifactId>
+ <version>1.23</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-changes-plugin</artifactId>
+ <version>2.12.1</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>3.3.1</version>
+ <configuration>
+ <configLocation>config/maven_checks.xml</configLocation>
+ <headerLocation>config/maven-header.txt</headerLocation>
+ </configuration>
+ <dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
+ <groupId>org.apache.maven.shared</groupId>
+ <artifactId>maven-shared-resources</artifactId>
+ <version>5</version>
</dependency>
<dependency>
- <groupId>org.apache.ant</groupId>
- <artifactId>ant</artifactId>
- <version>1.10.14</version>
+ <groupId>com.puppycrawl.tools</groupId>
+ <artifactId>checkstyle</artifactId>
+ <!-- last jdk 8 compatible version -->
+ <version>9.3</version>
</dependency>
+ </dependencies>
+ </plugin>
+ <plugin>
+ <artifactId>maven-jxr-plugin</artifactId>
+ <version>3.3.1</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-pmd-plugin</artifactId>
+ <version>3.21.0</version>
+ <configuration>
+ <targetJdk>1.8</targetJdk>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
+ <version>0.15</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.11.0</version>
+ <configuration>
+ <source>8</source>
+ <target>8</target>
+ <proc>none</proc>
+ </configuration>
+ </plugin>
+ <plugin>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <version>3.6.2</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-project-info-reports-plugin</artifactId>
+ <version>3.4.5</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-plugin-plugin</artifactId>
+ <version>${maven.plugin.version}</version>
+ </plugin>
+ <plugin>
+ <artifactId>maven-plugin-report-plugin</artifactId>
+ <version>${maven.plugin.version}</version>
+ </plugin>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>2.40.0</version>
+ <configuration>
+ <java>
+ <importOrder>
+ <file>config/maven-eclipse-importorder.txt</file>
+ </importOrder>
+ <removeUnusedImports />
+ <palantirJavaFormat>
+ <version>2.38.0</version>
+ </palantirJavaFormat>
+ <licenseHeader>
+ <file>config/maven-header-plain.txt</file>
+ </licenseHeader>
+ </java>
Review Comment:
you'are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
