mbien commented on code in PR #6329:
URL: https://github.com/apache/netbeans/pull/6329#discussion_r1411414616
##########
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/SingleSourceFileUtil.java:
##########
@@ -68,15 +73,15 @@ static FileObject
getJavaFileWithoutProjectFromLookup(Lookup lookup) {
return null;
}
- static boolean isSingleSourceFile(FileObject fObj) {
+ public static boolean isSingleSourceFile(FileObject fObj) {
Project p = FileOwnerQuery.getOwner(fObj);
if (p != null || !fObj.getExt().equalsIgnoreCase("java")) { //NOI18N
return false;
}
return true;
}
- static Process compileJavaSource(FileObject fileObject) {
+ public static Process compileJavaSource(FileObject fileObject) {
FileObject javac =
JavaPlatformManager.getDefault().getDefaultPlatform().findTool("javac");
//NOI18N
Review Comment:
Thinking about adding a JDK selector to the file properties of single source
programs for NB 21 to decouple it from the runtime JDK. Is something like this
planned? Will this still work in VSCode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
