lahodaj commented on code in PR #6789:
URL: https://github.com/apache/netbeans/pull/6789#discussion_r1422339211


##########
java/maven/test/unit/src/org/netbeans/modules/maven/NbMavenProjectImplTest.java:
##########
@@ -22,6 +22,9 @@
 import java.io.IOException;
 import java.lang.ref.Reference;
 import java.lang.ref.WeakReference;
+import java.nio.file.Files;

Review Comment:
   This seems probably unused.



##########
java/maven/apichanges.xml:
##########
@@ -83,6 +83,20 @@ is the proper place.
     <!-- ACTUAL CHANGES BEGIN HERE: -->
 
     <changes>
+        <change id="partial-maven-project">
+            <api name="general"/>
+            <summary>Support for partially loaded projects</summary>
+            <version major="2" minor="161"/>
+            <date day="3" month="10" year="2023"/>
+            <author login="sdedic"/>
+            <compatibility addition="yes" semantic="compatible"/>
+            <description>
+                Added a <a 
href="@TOP@/org/netbeans/modules/maven/api/NbMavenProject.html#getPartialProject-org.apache.maven.project.MavenProject-">
+                getPratialProject</a> that returns potentially incompletely 
loaded project instead of a mocked-up fallback (see <a 
href="@TOP@/org/netbeans/modules/maven/api/NbMavenProject.html#isErrorPlaceholder-org.apache.maven.project.MavenProject-">isErrorPlaceholder()</a>.

Review Comment:
   Typo:
   ```suggestion
                   getPartialProject</a> that returns potentially incompletely 
loaded project instead of a mocked-up fallback (see <a 
href="@TOP@/org/netbeans/modules/maven/api/NbMavenProject.html#isErrorPlaceholder-org.apache.maven.project.MavenProject-">isErrorPlaceholder()</a>.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to