junichi11 commented on code in PR #6873:
URL: https://github.com/apache/netbeans/pull/6873#discussion_r1434981878


##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java:
##########
@@ -2802,6 +2806,34 @@ public String extractUnqualifiedSuperClassName() {
             };
         }
 
+        static EnclosingClass forEnumDeclaration(final EnumDeclaration 
enumDeclaration) {
+            return new EnclosingClass() {
+                @Override
+                public String getClassName() {
+                    return enumDeclaration.getName().getName();
+                }
+
+                @Override
+                public Expression getSuperClass() {
+                    return null;
+                }
+
+                @Override
+                public List<Expression> getInterfaces() {
+                    return enumDeclaration.getInterfaes();

Review Comment:
   Yes, I also noticed it before. However, this is a method of the public 
packages. So, I didn't change it...
   
https://github.com/apache/netbeans/blob/a9f577647cdadff3ae7941ab80910dae00b47342/php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/TypeDeclaration.java#L74-L81
   
   Should we add `getInterface()` as a new method?
   e.g. 
   ```java
       /**
        * List of interfaces that this type implements / extends.
        *
        * @return interfaces
        * @deprecated instead, use {@link #getInterfaces()}
        */
       @Deprecated
       public List<Expression> getInterfaes() {
           return getInterfaces();
       }
   
       /**
        * List of interfaces that this type implements / extends.
        *
        * @return interfaces
        */
       public List<Expression> getInterfaces() {
           return Collections.unmodifiableList(interfaces);
       }
   
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to