matthiasblaesing commented on code in PR #6872:
URL: https://github.com/apache/netbeans/pull/6872#discussion_r1435346496
##########
enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/ide/WildflyJ2eePlatformFactory.java:
##########
@@ -334,21 +334,13 @@ String getDefaultJpaProvider() {
}
private boolean containsJaxWsLibraries() {
- File[] jaxWsAPILib = new
File(properties.getModulePath("org/jboss/ws/api/main")).listFiles(new
FilenameFilter() {
- @Override
- public boolean accept(File dir, String name) {
- return name.startsWith("jbossws-api") &&
name.endsWith("jar");
- }
- }); // NOI18N
+ File[] jaxWsAPILib = new
File(properties.getModulePath("org/jboss/ws/api/main"))
// NOI18N
+ .listFiles((File dir, String name) ->
name.startsWith("jbossws-api") && name.endsWith("jar")); // NOI18N
if (jaxWsAPILib != null && jaxWsAPILib.length == 1 &&
jaxWsAPILib[0].exists()) {
Review Comment:
My reading is, that the null check is required, but the existence check is
not necessary. However I don't expect this code to be a hot path, so it should
be harmless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
