bitrunner commented on PR #6859:
URL: https://github.com/apache/netbeans/pull/6859#issuecomment-1880187787

   Thanks for spending time reviewing and providing such helpful feedback on 
this @vieiro!
   
   I believe this thing has all the appropriate license headers now. (rat seems 
satisfied)
   
   I also managed to trick the meson project configuration dialog into doing 
more reasonable things when resized horizontally.  I didn't even think to try 
that.
   
   I also added support for project aware new files.  Right-click on something 
in the project explorer and selecting New should now present meson file options 
as well as options appropriate for whatever netbeans aware languages the meson 
project is configured for (C, C++, fortran, java, rust).
   
   As for the error shown in "Suggestion II/clarification" above,  I'm curious 
as to how the project got into that state.  The .netbeans/build/default 
directory exists but appears to be the root of a git repository instead of a 
meson build directory.  I cannot think of a way that could have been done by 
the cnd.meson module.  What's supposed to happen is netbeans should run "meson 
setup" to create that directory in response to any IDE invoked build action 
(setup, build, clean, clean and build, test, run).  If that directory is simply 
deleted, I think the clean and build action might work as desired (it will 
first run setup, then clean, then build).  I didn't think to add any automated 
defense for having an invalid netbeans managed build directory.  I can 
certainly add that though I'm hesitant to make it delete things it doesn't 
recognize which would be the only way to rectify that situation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to