lahodaj opened a new pull request, #6956:
URL: https://github.com/apache/netbeans/pull/6956

   Writing code along these lines:
   ```
   @ServiceProvider(service=|)
   public class Test implements Runnable {
   ...
   }
   ```
   
   Code completion invoked at the place `|` does not contain options like 
`Runnable`. The reason is that the `ServiceProviderProcessor.process` will fail 
(due to the incomplete code), and then `APTUtils.ErrorToleratingProcessor` 
ignores even the `getCompletions` invocation.
   
   The proposal is to split the `valid` flag in 
`APTUtils.ErrorToleratingProcessor` into two: one will be set if `init` fails, 
and this will block all the methods of the target processor, and one will be 
set when `process` fails, and that will only block the `process` method. As 
long as `init` passes, the `getCompletions` method may still be able to produce 
meaningful results, I think.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to