neilcsmith-net commented on code in PR #7029:
URL: https://github.com/apache/netbeans/pull/7029#discussion_r1479535543
##########
extide/gradle/src/org/netbeans/modules/gradle/spi/newproject/TemplateOperation.java:
##########
@@ -488,7 +488,7 @@ public Set<FileObject> execute() {
args.add("--gradle-version"); //NOI18N
args.add(version);
}
-
pconn.newBuild().withArguments("--offline").forTasks(args.toArray(new
String[0])).run(); //NOI18N
+ pconn.newBuild().forTasks(args.toArray(new String[0])).run();
//NOI18N
Review Comment:
@lkishalmi OK, I've made both the init and wrapper tasks only add
`--offline` if the global option is set. Please re-review.
Of course, the Tooling API isn't offline itself, and I'm not sure if it has
a configuration option to fail rather than download things?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
