lahodaj commented on code in PR #7034: URL: https://github.com/apache/netbeans/pull/7034#discussion_r1479935527
########## ide/extexecution.process/external/processtreekiller-2.0.1-license.txt: ########## @@ -1,6 +1,6 @@ Name: NetBeans processtreekiller Version: 2.0.1 -License: MIT +License: MIT-processtreekiller Review Comment: MIT is a generic template of the license, without copyright notices. This file is correct, but we should have the correct file in the `nbbuild/licenses` database as well. See the source license here: https://github.com/matthiasblaesing/netbeans-processtreekiller/blob/master/LICENSE ########## ide/slf4j.api/external/slf4j-api-1.7.36-license.txt: ########## @@ -1,10 +1,10 @@ Name: SLF4J Version: 1.7.36 -License: MIT-slf4j +License: MIT-slf4j-22 Review Comment: The source license for 1.7.36 is here: https://raw.githubusercontent.com/qos-ch/slf4j/v_1.7.36/LICENSE.txt ########## java/maven.embedder/external/apache-maven-3.9.6-javax.annotation-api-1.3.2-license.txt: ########## @@ -1,5 +1,5 @@ Name: Javax Annotation API -Version: 3.9.6 +Version: 1.3.2 Review Comment: Specifying more appropriate version, to reduce confusion. ########## platform/o.n.html.ko4j/external/ko4j-1.8.1-license.txt: ########## @@ -1,7 +1,7 @@ Name: Knockout4J Version: 1.8.1 Description: Knockout4J -License: Apache-2.0 +License: Apache-2.0-ko4j Review Comment: Updating the ko4j license to the version that is inside the binary - includes license terms for the Knockout library, in addition to the Apache 2.0 terms. ########## java/maven.embedder/external/apache-maven-3.9.6-slf4j-1.7.36-license.txt: ########## @@ -1,6 +1,6 @@ Name: slf4j Description: Part of Apache Maven Distribution -Version: 3.9.6 +Version: 1.7.36 Review Comment: Specifying more appropriate version, to reduce confusion. ########## ide/slf4j.jdk14/external/slf4j-jdk14-1.7.36-license.txt: ########## @@ -1,10 +1,10 @@ Name: SLF4J Version: 1.7.36 -License: MIT-slf4j +License: MIT-slf4j-22 Review Comment: The source license for 1.7.36 is here: https://raw.githubusercontent.com/qos-ch/slf4j/v_1.7.36/LICENSE.txt ########## ide/swing.validation/external/simplevalidation-1.14.1-notice.txt: ########## @@ -0,0 +1,3 @@ +ValidationAPI version 1.14.1 Review Comment: An attempt to add copyright from here: https://github.com/timboudreau/simplevalidation/blob/master/apache-license-2x.txt ########## java/maven.embedder/external/apache-maven-3.9.6-failureaccess-1.0.1-license.txt: ########## @@ -1,9 +1,9 @@ -Name: ValidationAPI -Description: Provides utilities for adding input validation to Swing forms quickly and easily -Version: 1.14.1 -Origin: GitHub +Name: Guava - Failure Access Library Review Comment: For Guava and failureaccess inside the Maven distribution, I'd propose to specify the license explicitly. It is Apache 2.0 License, of course, but having the license files allows us to specify metadata - like version, which then can be used to build dependency information, for example. ########## java/maven.embedder/external/apache-maven-3.9.6-httpclient-4.5.14-license.txt: ########## @@ -0,0 +1,565 @@ +Name: httpclient 4.5.14, as part of Maven distribution Review Comment: The license for httpclient is not Apache 2.0 - it is Apache 2.0 + MPL 2.0, please see: https://issues.apache.org/jira/browse/HTTPCLIENT-2317 https://issues.apache.org/jira/browse/MNG-8042 ########## webcommon/libs.graaljs/external/icu4j-67.1-license.txt: ########## @@ -1,39 +1,421 @@ Name: icu4j Description: icu4j license -License: MIT-icu4j +License: MIT-icu4j-58 Review Comment: Updating the license text to the text that is inside the binary. ########## ide/swing.validation/external/simplevalidation-1.14.1-license.txt: ########## @@ -4,6 +4,7 @@ Version: 1.14.1 Origin: GitHub License: Apache-2.0 URL: https://github.com/timboudreau/simplevalidation/ +Files: simplevalidation-1.14.1.jar simplevalidation-swing-1.14.1.jar Review Comment: Instead of using two license files, lets try to only use one. This is to simplify using of the notice file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
