lahodaj commented on code in PR #7034: URL: https://github.com/apache/netbeans/pull/7034#discussion_r1489508989
########## ide/slf4j.api/external/slf4j-api-1.7.36-license.txt: ########## @@ -1,10 +1,10 @@ Name: SLF4J Version: 1.7.36 -License: MIT-slf4j +License: MIT-slf4j-22 Review Comment: Done. ########## java/maven.embedder/external/apache-maven-3.9.6-httpclient-4.5.14-license.txt: ########## @@ -0,0 +1,565 @@ +Name: httpclient 4.5.14, as part of Maven distribution Review Comment: I've removed this change to avoid the controversy. Note that I've filled bugs against httpclient and Maven. So, while there's a potential for a regression on update, I think I did a lot to avoid that in the future. (And updating licenses is, sadly, not automatic when upgrading a library, so there's also an opposite risk - that Maven is fixed, but NetBeans is not.) No sure I understand the argument of "they have it wrong, so it is OK for us to have it wrong". (While I hear Neil's idea about distributing under Apache 2.0 - noone has confirmed that would be what ASF could or would want to do.) ########## ide/swing.validation/external/simplevalidation-1.14.1-notice.txt: ########## @@ -0,0 +1,3 @@ +ValidationAPI version 1.14.1 Review Comment: Ok. I've dropped this from this patch. I guess that while you may be technically right, being nice also may provides some advantages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
