mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491911346
##########
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##########
@@ -137,17 +135,9 @@ public static void
removeOpenProjectsListener(ChangeListener listener) {
public static Provider[] getSortedProjects(Provider[] projects) {
List<Provider> projectsArray = Arrays.asList(projects);
- Collections.sort(projectsArray,
- new Comparator() {
-
- @Override
- public int compare(Object o1, Object o2) {
- Provider p1 = (Provider) o1;
- Provider p2 = (Provider) o2;
-
- return
getDisplayName(p1).toLowerCase().compareTo(getDisplayName(p2).toLowerCase());
- }
- });
+ projectsArray.sort((Object o1, Object o2) ->
+ getDisplayName((Provider)
o1).toLowerCase().compareTo(getDisplayName((Provider) o2).toLowerCase())
Review Comment:
looking closer at the method it likely has unintended side effects since it
sorts the array in-place, and then it returns a copy via `toArray()` (which
makes no sense).
other implementations do copy first, sort it and return the copy:
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20getSortedProjects&type=code
should I change it to:
```java
public static Provider[] getSortedProjects(Provider[] projects) {
Provider[] sorted = Arrays.copyOf(projects, projects.length);
Arrays.sort(sorted, (p1, p2) ->
getDisplayName(p1).compareToIgnoreCase(getDisplayName(p2)));
return sorted;
}
```
@matthiasblaesing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
