oyarzun commented on PR #7132:
URL: https://github.com/apache/netbeans/pull/7132#issuecomment-1977220510

   > Can we use an environment variable (or system property at a push) to 
control this?
   > 
   > Would `System.getenv("APP_DOCK_NAME") != null` work? Probably not ideal.
   > 
   > We can always add additional options into 
https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/macos/main.swift.template
   
   I suppose you could set a flag via an environment variable and add some 
logic in `MainWindow.java` to use it to decided when to call `setIconImages` on 
macOS. 
   
   But launching NetBeans via the command line (shell script or Swift launcher) 
has other side effects like the icon in the Dock has the name `java` instead of 
`Apache NetBeans`. It also creates a new icon in the Dock if `Keep in Dock` was 
set on NetBeans previously.
   
   I think the true fix to these issues would be to have the macOS launcher to 
spawn the JVM using libjvm akin to what the [Windows 
launcher](https://github.com/apache/netbeans/blob/master/platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp)
 does. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to