neilcsmith-net commented on PR #7372:
URL: https://github.com/apache/netbeans/pull/7372#issuecomment-2105642777

   > close _focused_ terminal ...
   
   Let's call that _maybe_ close _focused_ terminal.  Not sure why as yet, but 
running through in the debugger a lot of times the right action is invoked, but 
it fails to close anything because `isVisibleInContainer` is false at 
https://github.com/apache/netbeans/blob/master/ide/terminal.nb/src/org/netbeans/modules/terminal/ioprovider/Terminal.java#L732
  That's a separate issue to having a duplicate key binding, but does show that 
having no key binding isn't much of an issue either.
   
   Thanks @mbien 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to