YannLeCorse opened a new issue, #178:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/issues/178
**How to reproduce**
I created a sample netbeans application and a sample module based on Maven.
On the module, I simply added the following dependency
```
<dependency>
<groupId>org.apache.servicemix.bundles</groupId>
<artifactId>org.apache.servicemix.bundles.spring-context</artifactId>
<version>5.3.28_1</version>
</dependency>
```
This is an OSGi artefacts where the Manifest declares `Bundle-Version:
5.3.28.1`. Version format is important for the issue.
Then compiled and ran the suite but as you can see on the following
screenshot, it's not able to start.
**Sample project**
[nbm-issue-sample-project-module.zip](https://github.com/user-attachments/files/16182098/nbm-issue-sample-project-module.zip)
**Issue**
When the nbm-maven-plugin generates the manifest of the module, it uses the
Maven version of dependencies.
With the dependency above, it creates something like
```
OpenIDE-Module-Module-Dependencies: org.netbeans.api.annotations.common/
1 > 1.49, org.apache.servicemix.bundles.spring_context > 5.3.28.1
```
When the Netbeans application starts, Netbeans reads the Manifest of the
OSGi dependency and considers only 3 numbers for the specification version
(5.3.28). This happens
[here](https://github.com/apache/netbeans/blob/2b8517543385a4848d72183f243ed8d28211f69f/platform/o.n.bootstrap/src/org/netbeans/ModuleData.java#L531)
Then it tries to compare it with the requested version (5.3.28.1).
As the requested version doesn't match the specification version generated
from the OSGi manifest, the module could not be loaded.
IMO, the issue is coming from the nbm-maven-plugin because it generates a
manifest that can't be managed properly with the current Netbeans specification
version logic. Thus I think we could address it here to ensure that the
produced manifest is in correct shape for Netbeans.
**How I'd like to address it**
The plugin already has a `AdaptNbVersion` class to process the version and
format it.
I'd like to enhance this class to add the following method adapted from
[Netbeans
code](https://github.com/apache/netbeans/blob/2b8517543385a4848d72183f243ed8d28211f69f/platform/o.n.bootstrap/src/org/netbeans/ModuleData.java#L531)
and use it at the end of the current `adaptVersion` process to ensure we
always produce a major.minor.micro version format in the generated Manifest
```
private static String computeSpecificationVersion(String v) {
int pos = -1;
for (int i = 0; i < 3; i++) {
pos = v.indexOf('.', pos + 1);
if (pos == -1) {
return v;
}
}
return v.substring(0, pos);
}
```
If needed, we can make that optional by adding a property on the goal but
from my understanding as soon as we have a dependency version with more than 3
numbers, it will fail at startup so I'd have enforce this and not expose a new
property.
If the approach is acceptable from your perspective, I'll create/submit the
PR so please let me know your throughs.
Cheers,
Yann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
