eirikbakke commented on PR #7463:
URL: https://github.com/apache/netbeans/pull/7463#issuecomment-2251587256

   > The added icons are not used at the moment, right?
   
   They _are_ actually used: ImageUtilities.loadImage automatically loads any 
SVG file that exists with the same name (but different extension) as the 
requested GIF or PNG icon. (So I wouldn't split up into two commits if this was 
the reason for doing so.)
   
   > So looking through the modified icons quickly should be possible with the 
right tool or process. Humans can interpret pictures quite fast.
   
   This is what the HTML page generated by [this 
script](https://github.com/apache/netbeans-tools/pull/67) is for:
   https://people.csail.mit.edu/ebakke/misc/netbeans-icons-240612.html
   
   > The simplest way to test would most probably to just create a dev build 
and use it for a few days.
   
   I've been using a NetBeans IDE build with these changes applied for a month 
now. Others are welcome to do the same, of course.
   
   > I have also only 2x 1080p screens here so I can't simulate scaling very 
well.
   For testing purposes, just seeing that icons are not "out of whack" 
(obviously missing, errors loading etc.) is probably good enough. The new icons 
are used at 100% scaling, too, just at a lower resolution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to