sid-srini commented on code in PR #7747: URL: https://github.com/apache/netbeans/pull/7747#discussion_r1757038086
########## java/java.completion/src/org/netbeans/modules/java/completion/JavaCompletionTask.java: ########## @@ -3926,7 +3926,7 @@ public boolean accept(Element e, TypeMirror t) { switch (e.getKind()) { case METHOD: ExecutableType et = (ExecutableType) asMemberOf(e, type, types); - results.add(itemFactory.createExecutableItem(env.getController(), (ExecutableElement) e, et, anchorOffset, null, typeElem != e.getEnclosingElement(), elements.isDeprecated(e), false, false, isOfSmartType(env, et, smartTypes), env.assignToVarPos(), true)); + results.add(itemFactory.createExecutableItem(env.getController(), (ExecutableElement) e, et, anchorOffset, null, typeElem != e.getEnclosingElement(), elements.isDeprecated(e), false, false, isOfSmartType(env, et, smartTypes), env.assignToVarPos(), true, false)); Review Comment: Thanks. I'll add the comment explaining the hard-coding to `false`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists