lahodaj commented on PR #7923: URL: https://github.com/apache/netbeans/pull/7923#issuecomment-2449239164
> catching NPEs isn't a good practice. This should be solved at the point where the NPE occurs if possible. +1 - catching a NPE is almost always the bad solution. If something can validly be null, there should be a `null` check. If something is believed to not to be `null`, and it is `null`, the source that is incorrectly providing `null` should be fixed. In this case, I have a question: if the `selectedProject`/`selectedRoot` are null, will this code be called again/the results be refreshed when they are set to non-null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
