mbien commented on code in PR #214:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/214#discussion_r1846715247
##########
nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java:
##########
@@ -176,15 +176,19 @@ public class CreateClusterAppMojo
"org.openide.modules.jre.JavaFX" //MNBMODULE-234
});
- @Component
- private ArtifactFactory artifactFactory;
+ private final ArtifactFactory artifactFactory;
- @Component
- private ArtifactResolver artifactResolver;
+ private final ArtifactResolver artifactResolver;
- @Component
+ @Parameter(defaultValue = "${session}", required = true, readonly = true)
protected MavenSession session;
+ @Inject
+ public CreateClusterAppMojo(ArtifactFactory
artifactFactory,ArtifactResolver artifactResolver) {
Review Comment:
space after `,`?
##########
nb-repository-plugin/src/main/java/org/apache/netbeans/nbm/repository/PopulateRepositoryMojo.java:
##########
@@ -247,19 +247,23 @@ public class PopulateRepositoryMojo
/**
* Repository system.
*/
- @Component
- protected RepositorySystem repositorySystem;
+ private RepositorySystem repositorySystem;
/**
* Maven ArtifactHandlerManager
*
*/
- @Component
private ArtifactHandlerManager artifactHandlerManager;
// parent handler in case we have one
private Parent artefactParent = null;
+ @Inject
+ public PopulateRepositoryMojo(ArtifactHandlerManager
artifactHandlerManager,RepositorySystem repositorySystem) {
Review Comment:
space after `,`?
##########
nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/CreateNbmMojo.java:
##########
@@ -178,19 +178,25 @@ public class CreateNbmMojo
@Parameter
private File licenseFile;
- @Component
- private ArtifactFactory artifactFactory;
+ private final ArtifactFactory artifactFactory;
/**
* Used for attaching the artifact in the project
*/
- @Component
- private MavenProjectHelper projectHelper;
+ private final MavenProjectHelper projectHelper;
- @Component
- private Map<String, ArtifactRepositoryLayout> layouts;
+ private final Map<String, ArtifactRepositoryLayout> layouts;
private static final SimpleDateFormat DATE_FORMAT = new
SimpleDateFormat("yyyy/MM/dd");
+ @Inject
+ public CreateNbmMojo(ArtifactFactory artifactFactory, MavenProjectHelper
projectHelper, Map<String, ArtifactRepositoryLayout>
layouts,MavenResourcesFiltering mavenResourcesFiltering) {
Review Comment:
space after `,`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
