mbien commented on code in PR #7974: URL: https://github.com/apache/netbeans/pull/7974#discussion_r1847497993
########## ide/ide.kit/nbproject/project.properties: ########## @@ -50,5 +50,5 @@ test.jms.flags=\ --add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \ --add-opens=java.desktop/javax.swing.text=ALL-UNNAMED \ --add-opens=java.desktop/sun.awt=ALL-UNNAMED \ - --add-modules=jdk.jdwp.agent,jdk.attach,jdk.jdi,jdk.jshell,java.compiler,jdk.compiler,jdk.management,jdk.unsupported,jdk.internal.le,jdk.internal.ed,jdk.internal.opt,jdk.internal.jvmstat \ + --add-modules=java.compiler \ Review Comment: JDK 23 added `jdk.internal.md` which we would have to add to the list. This would prevent the JVM from starting on JDKs <22. Adding only `java.compiler` seems to work, since according to the doc this adds all transitive deps automatically (we don't have to list them apparently). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
