sdedic commented on code in PR #7979:
URL: https://github.com/apache/netbeans/pull/7979#discussion_r1863452805
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java:
##########
@@ -374,6 +377,9 @@ private static ExplicitProcessParameters
createExplicitProcessParameters(Map<Str
if (!env.isEmpty()) {
bld.environmentVariables(env);
}
+ if (!projects.isEmpty()) {
Review Comment:
So, the goal here is to pass list of projects the **project action** should
apply to, rather than configure the launched application; the rest of
`ExplicitProcessParameters` is used to setup environment for the executed VM.
We do not have much support for "umbrella" actions in container projects at
this moment; so it's maybe better to introduce such explicit support in
`projects.api` module, given that the concept of `ProjectContainerProvider` is
here.
A simple bean like
```
public final class ContainedProjectFilter {
private List<Project> projectsToProcess;
}
```
would be sufficient, and usable (possibly!) for other actions. I thought
about an `Predicate<Project>`, but the caller can inspect the project structure
in advance and generate explicit information which is easier to process during
build.
The bean should be final with a nonpublic constructor + static factory, so
that it can be easily extended in the future (e.g. with a Builder).
When changing an API, bump version, record the change in `apichanges.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
