eirikbakke commented on PR #8024:
URL: https://github.com/apache/netbeans/pull/8024#issuecomment-2526389421

   Thanks for testing! Seeing whether the change makes a difference or not over 
time is very useful here.
   
   > I used this little program and got to 50 tries multiple times without a 
glitch: https://github.com/apache/netbeans/issues/3962#issuecomment-2371143019. 
I had this problem before.
   
   That's a good thing to test, in addition to regular IDE usage over some 
time. If you can, please try to switch to the NetBeans version that does not 
have the patch, and see if the test then starts producing the bug. I remember 
trying that particular test myself at some point without exhibiting the bug.
   
   Another good thing to check for is to see that and IllegalStateException is 
actually thrown for setContents every now and then. This is to make sure the 
patch actually has some effect. To see this you'd need to change the log 
message in the patch that currently reads "systemClipboard#getContents ISE, 
attempt {0}" to "systemClipboard#setContents ISE, attempt {0}", to distinguish 
it from the getContents case.
   
   setContents is a mutating operation unlike getContents, so I'd be a little 
more cautious about doing unconditional retries, unless we know that it fixes 
the bug. Probably we'd want to decrease the retry count a bit; though for 
testing purposes it can be useful to leave it as it is in the current version 
of the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to