sdedic commented on code in PR #7979:
URL: https://github.com/apache/netbeans/pull/7979#discussion_r1889738561
##########
java/java.source.base/src/org/netbeans/api/java/source/SourceUtils.java:
##########
@@ -1477,10 +1478,11 @@ public static void forceSource(CompilationController
cc, FileObject file) {
*
* @param info the ClasspathInfo used to resolve
* @param relativePath input source file path relative to the
corresponding source root
+ * @param nestedClass nested class which name is searched
* @return class name for the corresponding input source file
* @since 2.73
*/
- public static String classNameFor(ClasspathInfo info, String relativePath)
{
+ public static String classNameFor(ClasspathInfo info, String relativePath,
NestedClass nestedClass) {
Review Comment:
Sorry I missed this one. Paperwork for this API addition is missing -
`apichanges.xml` entry + update version for dependency on `java.source.base'
in maven + gradle modules which depend on this new API
##########
java/maven/src/org/netbeans/modules/maven/api/execute/RunConfig.java:
##########
@@ -79,6 +79,28 @@ public interface RunConfig {
String getActionName();
+ /**
+ * Options/switches passed to maven.
+ * @return a read-only copy of the current maven options
+ * @since 2.166
Review Comment:
The current master's version of java/maven is 2.166 as well, this should be
increased, 2.166 is over 2 months old already.
##########
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/TestProgressHandler.java:
##########
@@ -144,4 +150,27 @@ private String statusToState(Status status) {
throw new IllegalStateException("Unexpected testsuite status:
" + status);
}
}
+
+ private static final Pattern PATTERN = Pattern.compile("Gradle Test Run
:(.*):test"); // NOI18N
Review Comment:
Seems unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
