mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1905102085
##########
platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp:
##########
@@ -249,7 +249,7 @@ bool JvmLauncher::startInProcJvm(const char *mainClassName,
const std::list<std:
for (list<string>::const_iterator it = options.begin(); it !=
options.end(); ++it, ++i) {
const string &option = *it;
logMsg("\t%s", option.c_str());
- if (option.find("-splash:") == 0 && hSplash > 0) {
+ if (option.find("-splash:") == 0 && hSplash != (void *) NULL) {
Review Comment:
> or is the used C++ version too old for that?
@ExE-Boss hi! The build image is locked to [ubuntu
22](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime)
since the last LTS is soon eol. So the tooling env isn't super old.
I can change this if this is the cleaner way to do that comparison. Thanks
for the review btw!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
