matthiasblaesing commented on code in PR #8131:
URL: https://github.com/apache/netbeans/pull/8131#discussion_r1909284802


##########
enterprise/libs.fabric8/external/fabric8-2.17.2-license.txt:
##########


Review Comment:
   Name should be `fabric8-6.7.0-license.txt` (the version number in the 
license file should match the version of the target library. For single jars 
this is enforced.



##########
enterprise/libs.fabric8/external/fabric8-2.17.2-license.txt:
##########
@@ -1,9 +1,9 @@
-Name: Jackson
-Description: Jackson is a high-performance JSON processor for Java.
+Name: Fabric8
+Description: Java client for Kubernetes & OpenShift.
 License: Apache-2.0
 Origin: https://github.com/FasterXML/jackson

Review Comment:
   Wrong origin



##########
enterprise/libs.fabric8/external/fabric8-2.17.2-license.txt:
##########
@@ -1,9 +1,9 @@
-Name: Jackson
-Description: Jackson is a high-performance JSON processor for Java.
+Name: Fabric8
+Description: Java client for Kubernetes & OpenShift.
 License: Apache-2.0
 Origin: https://github.com/FasterXML/jackson
 Version: 2.17.2

Review Comment:
   Wrong version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to