matthiasblaesing commented on code in PR #8153:
URL: https://github.com/apache/netbeans/pull/8153#discussion_r1917118372


##########
enterprise/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/admin/AdminFactoryTest.java:
##########
@@ -168,15 +168,15 @@ public void testGetInstanceforVersionGF6() {
     }
     
     /**
-     * Test factory functionality for GlassFish v. 7.0.15
+     * Test factory functionality for GlassFish v. 7.0.21
      * <p/>
      * Factory should initialize REST {@code Runner} and point it to
      * provided {@code Command} instance.
      */
     @Test
     public void testGetInstanceforVersionGF7() {
         GlassFishServerEntity srv = new GlassFishServerEntity();
-        srv.setVersion(GlassFishVersion.GF_7_0_15);
+        srv.setVersion(GlassFishVersion.GF_7_0_21);

Review Comment:
   What is the intention of this change?



##########
enterprise/glassfish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/utils/EnumUtilsTest.java:
##########


Review Comment:
   For the future I don't think these changes are necessary. They don't test 
the version, just the eh operators work. That is independend on newer versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to