mbien commented on code in PR #8175:
URL: https://github.com/apache/netbeans/pull/8175#discussion_r1924290877


##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties:
##########
@@ -18,6 +18,9 @@
 nb.dark.theme=true
 nb.preferred.color.profile=FlatLaf Dark
 
+@foreground=#cccccc
+# switch to white if the text contrast is not enough - works somewhat similar 
to NB's html renderer
+@selectionForeground=contrast(@selectionBackground, @background, #ffffff, 25%)

Review Comment:
   even though this was not the original intention, this does now also allow 
setting accent=foreground. e.g:
   
   ```
   @foreground=#d1d1d1
   @accentColor=#d1d1d1
   ```
   is now useable with flatlaf dark, cc @eirikbakke, since you mentioned you 
use brighter foregrounds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to