matthiasblaesing commented on PR #8187: URL: https://github.com/apache/netbeans/pull/8187#issuecomment-2613245154
What I see in the directories are the files created by indexing. Sure, I can mess with the production code to make these stoppable, but if retrying deletion in only test code, I think that is the better idea. > if something is still writing to the folder while the test is trying to delete it, the test probably should have to make sure first that this task is stopped. Sure, you just need to wait. At some point the parsing/scanning infrastructure will settle and you can delete. > Iterating on delete until the directory is gone does hide the problem, since the next test case could end up seeing unexpected files still. > > If this is specific to the groovy tests, lets give the groovy tests their own delete method - the retry loop shouldn't run everywhere IMO since it can hide more problems. This is the _cleanup_ code. _Not_ the test code. It is best effort and if it improves the situation. Take it leave it, I'm willing to step away from this and close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
