mbien commented on PR #8199: URL: https://github.com/apache/netbeans/pull/8199#issuecomment-2617122966
> Looks good. Slightly concerned at proliferation of code that relies on specifics of our versioning scheme. yes, we have several instances were it would be useful to query the NB version etc ([nb version](https://github.com/mbien/netbeans/blob/db839d6ad814567d120b3bdb96a13d0c21292e8e/java/maven/src/org/netbeans/modules/maven/options/MavenVersionSettings.java#L46-L48), javac versions https://github.com/apache/netbeans/pull/3274). But this here is just a "best effort" mechanism and version is just one attribute to probe for, the other are time stamps etc. If this fails it fails quietly and is no show stopper. > The next time we need that, something to possibly considering abstracting into Places.. yep! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
