neilcsmith-net commented on issue #8207: URL: https://github.com/apache/netbeans/issues/8207#issuecomment-2621399397
> second paragraph is referring to: "since the point was brought up that all (or most) icons should be loaded with localized=true" Given that point was made by me, let's clarify what was meant. :smile: All icons / images _should_ be _brandable_. I agree with Eirik that very few images actually need to be _localizable_. At this point, I wouldn't look to fix the usages across the code base. We might just consider existing uses on a case by case basis if a downstream consumer complains about un-brandable usage. If we do want to look at this from a branding or performance perspective, I would look at `ImageUtilities` itself, and ensure branding tokens are taken into account on the non-localized path, then make localization more opt-in. That would reduce the number of suffixes that are searched quite significantly. It's also a minor behaviour change, but one possibly worth considering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
