neilcsmith-net commented on code in PR #220:
URL:
https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/220#discussion_r1959518460
##########
nbm-maven-plugin/src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java:
##########
@@ -1091,6 +1086,12 @@ static Map<String, Set<String>>
computeClusterOrdering(Map<String, Set<String>>
return cluster2depClusters;
}
+ private static Set<String> intersection(Set<String> first,
Collection<String> second) {
+ HashSet<String> intersection = new HashSet<>(first);
Review Comment:
Are you 100% sure that none of the sets passed in here are ordered?
Replaced code states it maintains iteration order of `first`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
