tmysik commented on code in PR #8340:
URL: https://github.com/apache/netbeans/pull/8340#discussion_r1997649303
##########
php/php.editor/src/org/netbeans/modules/php/editor/typinghooks/PhpCommentGenerator.java:
##########
@@ -114,6 +114,8 @@ private static void generateFunctionDoc(BaseDocument doc,
int offset, int indent
if (i.hasReturn) {
generateDocEntry(doc, toAdd, "@return", indent, null,
i.getReturnType()); // NOI18N
+ } else {
+ generateDocEntry(doc, toAdd, "@return", indent, null, Type.VOID);
// NOI18N
Review Comment:
Nitpick: maybe simpler?
```suggestion
generateDocEntry(doc, toAdd, "@return", indent, null,
i.hasReturn ? i.getReturnType() : Type.VOID); // NOI18N
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
