mbien commented on code in PR #8407:
URL: https://github.com/apache/netbeans/pull/8407#discussion_r2033930534
##########
platform/openide.dialogs/src/org/openide/NotifyDescriptor.java:
##########
@@ -129,24 +129,45 @@ public class NotifyDescriptor extends Object {
*/
public static final String PROP_INFO_NOTIFICATION = "infoNotification"; //
NOI18N
+ /**
+ * Used to be a <code>new Integer(JOptionPane.FOO_OPTION)</code> instance.
+ *
+ * For compatibility reasons the public Object constants must have distinct
+ * identity, but equals must behave like Integer's equals and compare only
+ * the wrapped int like a Record.
+ */
+ private record ReturnValue(int option) {
Review Comment:
`hashCode` probably doesn't need to be implemented, but by doing it, is uses
the same hash function of the original Integer type. You can take a look at the
jdk impl.
Two records are equal if both are from the same class and all record
components are equal. This is the same contract as Integer, so no custom impl
needed. See unit test.
I might make it Comparable and Serializable too, although this pushes the
"what if" scenarios a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
