matthiasblaesing commented on PR #3995: URL: https://github.com/apache/netbeans/pull/3995#issuecomment-2932278127
@ratcashdev lets simplify the history a bit please. A deep history with multiple merges from master makes it difficult so see what is really going on and if necessary to revert after merge if necessary. When doing that, please ensure, that all commits hold your full real name and email address (former is missing, latter is present). I will not have time to really look at this the next few days, but what I saw immediatly was the change in `Classpath.java`: What is the idea here? As far as I can see this breaks the existing contract. `findPath` is called by `findResource`, if I'm not missing something obvious, people can create a resouce `dummy$name`. That file was locateable before and is not afterwards. This looks as if you want to delegate resolving `Demo$Nested.class` to `Demo.class`, but from my POV that is the wrong location as it has not context to judge whether that modification is fine or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
