mbien commented on code in PR #8572:
URL: https://github.com/apache/netbeans/pull/8572#discussion_r2187879041


##########
java/java.completion/test/unit/src/org/netbeans/modules/java/completion/JavaCompletionTask114FeaturesTest.java:
##########
@@ -70,6 +71,8 @@ public void testAfterTypeParamInRecParam() throws Exception {
         performTest("Records", 890, null, "extendsKeyword.pass", SOURCE_LEVEL);
     }
     
+    // TODO "compact source file" feature wraps the compilation unit into 
additional "final class Test"?
+    @Ignore
     public void testInsideRecAfterStaticKeyWord() throws Exception {
         performTest("Records", 918, "R", 
"typesRecordStaticMembersAndVars.pass", SOURCE_LEVEL);
     }

Review Comment:
   while debugging, I noticed that javac 25 wrapped the `Records` test code 
into another `final Class Test` type:
   ```java
   final class Test {
       
       Test() {
           super();
       }
       
       public class Test {
           
           public Test() {
               super();
           }
           public record Records;
           
           <R extends Number, R1>(ERROR) <error>() {
               (ERROR);
           }
           public static R <error>;
       }
       
       public static void main(String args) {
           record Record1;
           @Ov
           (ERROR) <error>;
           {
           }
           record Rec;
           {
           }
           (ERROR);
       }
       (ERROR)
   }
   ```
   this might be the reason why the completion results differ. The auto 
completion does look correct when I test it manually using a dev build and the 
`Records` test file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to