mbien commented on code in PR #8645:
URL: https://github.com/apache/netbeans/pull/8645#discussion_r2198826856
##########
ide/diff/src/org/netbeans/modules/diff/builtin/visualizer/editable/EditableDiffView.java:
##########
@@ -192,6 +198,9 @@ public EditableDiffView(final StreamSource ss1, final
StreamSource ss2, boolean
actionsEnabled = ss2.isEditable();
diffMarkprovider = new EditableDiffMarkProvider();
+ lineEnding1 = detectLineEnding(ss1);
+ lineEnding2 = detectLineEnding(ss2);
Review Comment:
only took a quick glance but this is likely too early in the timeline, the
two document panels are initialized later asynchronously:
https://github.com/Chris2011/netbeans/blob/097cde825b2732aeb34484087fe5fbcb78830993/ide/diff/src/org/netbeans/modules/diff/builtin/visualizer/editable/EditableDiffView.java#L320-L325
another place to put this could be potentially the update diff task:
https://github.com/Chris2011/netbeans/blob/097cde825b2732aeb34484087fe5fbcb78830993/ide/diff/src/org/netbeans/modules/diff/builtin/visualizer/editable/EditableDiffView.java#L1583-L1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
