sdedic opened a new pull request, #8693: URL: https://github.com/apache/netbeans/pull/8693
During investigation of #8681 @thurka and me encountered strange thing: some tests in the vsnetbeans testsuite seemed to fail, but overall the `ant test` task succeeded. See for example [build-vscode-ext logs](https://github.com/apache/netbeans/actions/runs/16549006990/job/46920286441) , look for ``` Test org.netbeans.modules.nbcode.integration.VerifyPresentUpdateCentersTest FAILED (crashed) ``` Despite that, the `test-vscode-ext` task continued to run, covering up this error. I've traced the issue down to NB harness: for module suites, [suite.xml](https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/release/suite.xml#L584) defines the default property value. But `test*` tasks react on [**existence** of that property](https://github.com/apache/netbeans/blob/master/nbbuild/templates/common.xml#L773) -- no matter if the value is true or false. So it's not possible to ENABLE test failures in suite tests, in fact: if the property is not defined at all, it will default to true and that value will be passed to sub-ant. If there's any other value it will be passed and `unless` will react since the property is defined and non empty. The intention is clear: let all modules run their tests and produce the test report. I've changed the common template so that it reacts ONLY to `true` value; this preserves the current behaviour. If `project.properties` of the module suite or commandline arg defines the property to `false`, a failed module test will fail the whole suite test. This is better for CI. Note: The `vsnetbeans` integration code (including the failing tests) are going to be removed - see #8661, so the failing tests will be fixed in the new repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
