matthiasblaesing commented on PR #8700: URL: https://github.com/apache/netbeans/pull/8700#issuecomment-3146430294
I think VanillaCompileWorker needs more null checks. The problem with the "this needs a reproducer" is, that reproduction of these situations is difficult, as it might be a mix of "source in state of editing", incomplete indexing, $other reason. If there are other patterns like the problematic one, then sure, lets also guard them, but also lets be real, that not all cases can be caught. I too often see exception from the javac infrastructure and that hast to stop, if every change is vetoed by "needs a reproducer", even when the reporter clearly says, that he can't, this will always be a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
